Conversation
See test results for failed build of commit 18930f906e |
Member
Author
|
https://trac.wxwidgets.org/ticket/19086 has a suggested fix/workaround for this so I'm investigating the alternative option |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#8859
Summary of the issue:
Right-to-left languages trigger a RTL Layout for the StaticBoxSizer. UI features either clip with each other or do not display with the StaticBox.
https://trac.wxwidgets.org/ticket/19086
Description of how this pull request fixes the issue:
A new StaticBoxSizer is introduced that enforces a LTR Align for the StaticBox. This only minimizes the problem as the StaticBox header layout is aligned to the left where it should be aligned for the right for people with an RTL locale.
Manually overriding the layout for StaticBoxes within a to LTR is a temporary workaround, creating a new issue that the text label is aligned left rather than right.
Testing strategy:
Visually compare GUI features outlined in #8859 between an LTR language such as English and an RTL language such as Farsi.
Known issues with pull request:
Aligns text to the left for groupings (Static Box labels), regardless of system preference, This is a documented issue for other GUI features in #638. A proper fix to this is blocked by https://trac.wxwidgets.org/ticket/19086
Change log entry:
Section: Bug fixes
Fixes some GUI features clipping or being visually hidden when using a language that is read right-to-left.
Code Review Checklist: