Skip to content

Force Left-To-Right Layout for StaticBox groupings - #12115

Closed
seanbudd wants to merge 5 commits into
masterfrom
fix-8859
Closed

Force Left-To-Right Layout for StaticBox groupings#12115
seanbudd wants to merge 5 commits into
masterfrom
fix-8859

Conversation

@seanbudd

@seanbudd seanbudd commented Mar 4, 2021

Copy link
Copy Markdown
Member

Link to issue number:

#8859

Summary of the issue:

Right-to-left languages trigger a RTL Layout for the StaticBoxSizer. UI features either clip with each other or do not display with the StaticBox.

https://trac.wxwidgets.org/ticket/19086

Description of how this pull request fixes the issue:

A new StaticBoxSizer is introduced that enforces a LTR Align for the StaticBox. This only minimizes the problem as the StaticBox header layout is aligned to the left where it should be aligned for the right for people with an RTL locale.

Manually overriding the layout for StaticBoxes within a to LTR is a temporary workaround, creating a new issue that the text label is aligned left rather than right.

Testing strategy:

Visually compare GUI features outlined in #8859 between an LTR language such as English and an RTL language such as Farsi.

Known issues with pull request:

Aligns text to the left for groupings (Static Box labels), regardless of system preference, This is a documented issue for other GUI features in #638. A proper fix to this is blocked by https://trac.wxwidgets.org/ticket/19086

Change log entry:

Section: Bug fixes

Fixes some GUI features clipping or being visually hidden when using a language that is read right-to-left.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd self-assigned this Mar 4, 2021
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 18930f906e

@seanbudd seanbudd changed the title Create and implement forced LTR StaticBoxSizer Force Left-To-Right Layout for StaticBox groupings Mar 5, 2021
@seanbudd

seanbudd commented Mar 9, 2021

Copy link
Copy Markdown
Member Author

https://trac.wxwidgets.org/ticket/19086 has a suggested fix/workaround for this so I'm investigating the alternative option

@seanbudd seanbudd reopened this Mar 15, 2021
@seanbudd seanbudd closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants